Resident Evil 4 some object edges looks pixelated

vkd3dclosed

HansKristian-Work/vkd3d-proton#1522 · opened 2023-04-19 by ghost · updated 2023-04-20 · 13 comments · github

?ghost 2023-04-19 github

Enabling CACAO in RE engine titles* make things look pixelated in object edges (not sure if the same happens on Windows)

Some low quality footage because youtube compression is a piece of ****
https://www.youtube.com/watch?v=lF7wkS49oPQ

Software information

RESIDENT EVIL 4

other games affected:
RESIDENT EVIL 7 (the easiest one to see the issue on this list)
RESIDENT EVIL 2
RESIDENT EVIL 3
and maybe Village too, not sure about this one

System information

GPU: RX 6600
Driver: RADV - Mesa 23.0.2
Wine version: Proton 8.0-1
VKD3D-Proton version: only god knows

Mmbriar 2023-04-19 github

Is this the same as https://github.com/HansKristian-Work/vkd3d-proton/issues/1460 for the Demo? Maybe some more shader hashes need to be added to the quirk list..

HHansKristian-Work maintainer 2023-04-19 github

If they modified the shader slightly, that would explain it, yes ... Looks very much like the broken CACAO.

?ghost 2023-04-19 github

did it ever got fixed for older games?
i was getting the same issue with proton experimental last week on RE7

HHansKristian-Work maintainer 2023-04-19 github

I was not aware there were issues on other RE titles. Guess we'll have to workaround there too :<

Mmbriar 2023-04-19 github

All of these games received patches recently. I'm pretty sure CACAO wasn't even available in RE2 a year ago.

?ghost 2023-04-19 github

All of these games received patches recently. I'm pretty sure CACAO wasn't even available in RE2 a year ago.

yeah i'm aware of that, the ray tracing patches added CACAO
and is broken since the RT patches were released

SSamPurple22 2023-04-19 github

Hi @kassindornelles

To find the VKD3D-Proton version, do:

~/steamlib1/steamapps/common/Proton 8.0/dist/lib64/wine/vkd3d-proton$ cat version
 08909d98565065994612e529feb0cad04e498a8e vkd3d-proton (vkd3d-1.1-3174-g08909d98)

Funny line though :)

?ghost 2023-04-20 github

Looks like is fixed on main branch, so proton is probably using something older, but from what i've seen theres no workaround for the other RE engine games (re2, 3 and 7)

Mmbriar 2023-04-20 github

FWIW, i think the shader hashes are different for the older RE games, I tried this

diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c
index c0883262..5faed388 100644
--- a/libs/vkd3d/device.c
+++ b/libs/vkd3d/device.c
@@ -590,7 +590,10 @@ static const struct vkd3d_shader_quirk_meta application_shader_quirks[] = {
     /* Wo Long: Fallen Dynasty (2285240) */
     { VKD3D_STRING_COMPARE_EXACT, "WoLong.exe", &wolong_quirks },
     /* Resident Evil 4 (2050650) */
+    { VKD3D_STRING_COMPARE_EXACT, "re2.exe", &re4_quirks },
+    { VKD3D_STRING_COMPARE_EXACT, "re3.exe", &re4_quirks },
     { VKD3D_STRING_COMPARE_EXACT, "re4.exe", &re4_quirks },
+    { VKD3D_STRING_COMPARE_EXACT, "re7.exe", &re4_quirks },
     { VKD3D_STRING_COMPARE_EXACT, "re4demo.exe", &re4_quirks },
     /* MSVC fails to compile empty array. */
     { VKD3D_STRING_COMPARE_NEVER, NULL, NULL },

for RE7 and it didn't fix it.

HHansKristian-Work maintainer 2023-04-20 github

Proton 8 has a slightly older vkd3d-proton from when we didn't have the workaround, so that is expected.

HHansKristian-Work maintainer 2023-04-20 github

@kassindornelles Does this repro in RE2 for you? Nvm, it does repro in RE2 now.

?ghost 2023-04-20 github

just to update: i could not reproduce on RE3, i reproduced easily on RE2 and RE7 here :ok_hand:

HHansKristian-Work maintainer 2023-04-20 github

Fixed on master. RE2 and 7 were affected.