I've edited this issue, because DS3, DS2:SOTFS, DS2, and DS1:Prepare to Die all have the buffer overflow on exit. So it seems its an issue with the Souls games specifically...
It seemed the cleanest to me to update this issue report, instead of making 4 separate issue reports, so that all information is in one place, instead of scattered on 4 issue reports.
But maybe for tracking each overflow for each game, it might be better to separate out the issues?
So @kisak-valve, could you tell me which of these you prefer?
I've added Proton logs and steps to reproduce to this issue report, both for the affected games and for some not affected games, so that the developers can compare those logs and terminal output.
Hello @HonkingGoose, as long as there's a decent chance the root cause is the same, there's no harm in tracking this issue across multiple game titles. For tracking purposes, I read this as Dark Souls III (whitelisted) has the issue, and the other Dark Souls titles are potentially providing additional hints.
If someone finds evidence that there's a difference between the games, we can re-evaluate later.
Does this result in a problem playing the games?
Hello @aeikum
The buffer overflow doesn't result in a problem playing the games. The buffer overflow seems to happen when exiting the games from the main menu in the normal manner.
From the wikipedia page on Buffer overflow:
Exploiting the behavior of a buffer overflow is a well-known security exploit. On many systems, the memory layout of a program, or the system as a whole, is well defined. By sending in data designed to cause a buffer overflow, it is possible to write into areas known to hold executable code and replace it with malicious code, or to selectively overwrite data pertaining to the program's state, therefore causing behavior that was not intended by the original programmer. Buffers are widespread in operating system (OS) code, so it is possible to make attacks that perform privilege escalation and gain unlimited access to the computer's resources.
This overflow might pose a security risk to users of Dark Souls games and/or Proton/wine. Therefore I thought I should report it, so that people with more knowledge can look into it.
Somebody seems to have some issues relating to the buffer overflow:
https://github.com/ValveSoftware/Proton/issues/478#issuecomment-480461063
Quote (relevant part emphasized by me)
After updating to Ubuntu 18.10 Cosmic Cuttlefish I've been getting really bad stuttering on any version of Proton (even though the FPS is 60). When I restart my PC after playing the game I get a warning saying Buffer Overflow detected and it points to the Dark Souls III exe file.
Not sure why this started after upgrading my Ubuntu but would love a fix for it. Sick of restarting my PC just to stop it from lagging.
I always quit game with Alt+F4, and always get Buffer overflow like you. Cannot fix this, also it seems do not have any problems with performance or anything else.
Seems like the crucial info is missing here: does this buffer overflow happen in Windows as well?
Description of issue:
When running Steam from the terminal, these Dark Souls games have a buffer overflow when exiting the game:
Did not test: DARK SOULS™: REMASTERED (570940), I don't have this game. So I don't know if the remaster has this issue too...
Other games do not register a buffer overflow when exiting the game:
System Information
DARK SOULS™ III (374320) Buffer overflow.
steam-374320.log
Steps to reproduce DS3:
Terminal output:
DARK SOULS™ II: Scholar of the First Sin (335300) Buffer overflow.
steam-335300.log
Steps to reproduce DS2:SOTFS:
Terminal output:
DARK SOULS™ II (236430) Buffer overflow.
steam-236430.log
Steps to reproduce DS2:
Terminal output:
DARK SOULS™: Prepare To Die Edition (211420) Buffer overflow.
steam-211420.log
Steps to reproduce DS: Prepare To Die:
Terminal output:
The Awesome Adventures of Captain Spirit (845070) No buffer overflow.
steam-845070.log
Steps to reproduce Captain Spirit:
Terminal output:
Sid Meier's Pirates! (3920) No buffer overflow:
steam-3920.log
Steps to reproduce Sid Meier's Pirates!:
Terminal output:
Airport Madness: World Edition (369290) No buffer overflow:
steam-369290.log
Steps to reproduce Airport Madness: World Edition:
Terminal output: