protonscr

[GoldSource] Copy from console on Windows: lose tail chars.

steamclosed reviewedMOVED: Counter‐Strike
ValveSoftware/steam-for-linux#1596 · opened 2013-02-12 by LevShisterov · updated 2013-02-14 · 6 comments · github
LLevShisterov 2013-02-12 github

When you selects and copy several lines of text from console there are missing chars at the end, like this:

] version
Protocol version 48
Exe version 1.1.2.1/2.0.1624.237 (valve)
Exe build: 16:05:41 Jun 15 2009 (45

A bit annoying for years...
Would be nice if you will fix it.
It is in GameUI code in function vgui::RichText::CopySelected, when you count amount of characters to copy, take into account that on Windows it is 2 chars (\r\n) at the line end.
Thanks!

Aalfred-valve maintainer 2013-02-13 github

Thanks for pointing to the line of code with the bug, that makes things much easier :)

LLevShisterov 2013-02-14 github

Issue is still here in:
] version
Protocol version 48
Exe version 1.1.2.1/Stdio (valve)
Exe build: 15:00:41 Feb 13 2013 (5956)
But now it is in some random form. Hard to describe current behavior. A friend of me did tests. Sometimes it can loose chars, sometimes not, even if same text is selected. I will try to test myself later.

Aalfred-valve maintainer 2013-02-14 github

If you can find a solid way to reproduce it then I can fix that, thanks.

LLevShisterov 2013-02-14 github

Okay. I changed my HL to beta too.
For you to be sure: I even moved out half-life folder from my account's folder to remove any remnants there would be. I didn't touched gcfs though. Verified game cache.
Launched. Typed "version" and thats it (I marked start and end with " char):

"] version
Protocol version 48
Exe version 1.1.2.1/Stdio (valve)
Exe build: 15:00:41 Feb 13 2013 (595"

Typed "version" again:

"] version
Protocol version 48
Exe version 1.1.2.1/Stdio (valve)
Exe build: 15:00:41 Feb 13 2013 (5956)
] version
Protocol version 48
Exe version 1.1.2.1/Stdio (valve)
Exe build: 15:00:41 Feb 13 2013 "

I selected whole output of course. There are still missing chars at the end.
Windows 7 64bit.
Do you need video of how I am doing this or words are just enough?
Thanks.

Aalfred-valve maintainer 2013-02-14 github

This description is enough, I'll try to reproduce it.

LLevShisterov 2013-02-14 github

FYI, I checked the code, it looks the same as before (but not sure though, was a quick look). May be a deploy issue...

Nothing extracted yet.