[HL1/CS] Say/Say_team text corruption with backspace

steamclosed High priorityreviewedMOVED: Counter‐Strike

ValveSoftware/steam-for-linux#1654 · opened 2013-02-13 by AnAkkk · updated 2013-02-17 · 14 comments · github

AAnAkkk 2013-02-13 github

Since the last update, I am now able to use éàè characters in say/say_team.
If I try to erase any of them before sending my chat message though, the say/say_team text input thing gets corrupted, and it replaces the erased character by some random charaters/text.

Before backspace:
beforebackspace

After one backspace:
afterbackspace

As you can see, it seems to have copied a part the net_graph text.

Jjohndrinkwater 2013-02-13 github

Have had it copy a ‘live’ section of the k/s output after I pressed backspace, it kept animating in the conversation view until it hid.

Aalfred-valve maintainer 2013-02-13 github

What KB layout are you running?

AAnAkkk 2013-02-13 github

AZERTY.

Aalfred-valve maintainer 2013-02-13 github

I can't make this happen, do you just start a local server, hit U, type some é's and then backspace doesn't work right? I do see #1663 happening, we are deleting a since char value rather than a character codepoint at a time, so perhaps that is related?

AAnAkkk 2013-02-13 github

Yes, but backspace do work, it just replaces the character with a bunch of other letters/words. I am unable to send the chat message after this happens though.

MMrSchism 2013-02-13 github

Honestly, I'm more troubled by what John said when he posted:

Have had it copy a ‘live’ section of the k/s output after I pressed backspace, it kept animating in the conversation view until it hid.

Seems more likely related to the issue at hand than to 1663 (unless, of course, 1663 and this one are related, that is).

Aalfred-valve maintainer 2013-02-13 github

I mustn't understand your comment @johndrinkwater , could you post me a picture perhaps?

MMrSchism 2013-02-14 github

I think that when he hit backspace, it wound up replacing what he tried to remove with constantly changing characters, possibly relating to data throughput.

Aalfred-valve maintainer 2013-02-14 github

I think the previous code would have still been well behaved and not left an unterminated buffer, but with the update today I made it even more robust.

AAnAkkk 2013-02-14 github

Indeed, the last update solved this.

Jjohndrinkwater 2013-02-14 github

OK, found a reproducable case on the latest update with net_graph 1 on, a combination of typing and deleting mixed characters:
type this: ¹²³123¹²³123, delete back to ¹²³123¹²³1, then press ‘¹’, you get some of the net_graph

http://steamcommunity.com/sharedfiles/filedetails/?id=127131577

Aalfred-valve maintainer 2013-02-15 github

How would I type a "¹"?

Aalfred-valve maintainer 2013-02-15 github

I believe the beta update from today fixes this, reopen if not (and tell me how to type that whacky character :)

Jjohndrinkwater 2013-02-17 github

That fixed it!
UK keyboard, Linux, hold right alt and press 1:
Screenshot from 2013-02-17 15:45:26

Nothing extracted yet.