QA installer package

steamclosed reviewed

ValveSoftware/steam-for-linux#276 · opened 2012-12-22 by anyc · updated 2013-01-09 · 3 comments · github

Aanyc 2012-12-22 github

Gentoo's QA tool objects missing semicolons in the steam.desktop file (see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html ). Please apply the following patch:

--- steam.desktop_orig  2012-12-22 14:10:47.502717440 +0100
+++ steam.desktop       2012-12-22 14:11:47.707332334 +0100
@@ -5,9 +5,9 @@
 Icon=steam
 Terminal=false
 Type=Application
-Categories=Network;FileTransfer;Game;
-MimeType=x-scheme-handler/steam
-Actions=Store;Community;Library;Servers;Screenshots;News;Settings;Friends
+Categories=Game;
+MimeType=x-scheme-handler/steam;
+Actions=Store;Community;Library;Servers;Screenshots;News;Settings;Friends;

 [Desktop Action Store]
 Name=Store

Categories can contain more than one entry, but (imho) steam should only appear in the Games folder of the startmenu.

MMailaender 2012-12-22 github

This also applies to openSUSE which requires strict http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html You might want to use Game; Amusement; (those subcategories look better in KDE menus). http://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories#Game

We currently use an RPM macro to fix this: https://build.opensuse.org/package/view_file?expand=1&file=steam.spec&package=steam&project=games %suse_update_desktop_file

Jjohnv-valve maintainer 2012-12-31 github

Added the trailing ; but leaving the Categories the same for now. Steam does more than games.

Aanyc 2012-12-31 github

It does, but I would not expect to find it in the network or file transfer section of the start menu. According to http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html, "category" determines in which menu the entry appears.

But this is a subjective opinion. Issue can imho be closed when QA points are addressed.

Nothing extracted yet.