protonscr

driverhelper.py is executed not only for ubuntu (which obviously fail)

steamclosed reviewed
ValveSoftware/steam-for-linux#47 · opened 2012-12-20 by swiftgeek · updated 2014-06-08 · 15 comments · github
Sswiftgeek 2012-12-20 github

.local/share/Steam/ubuntu12_32/driverhelper.py

2 possible solutions:
• Make steam not run that script if ubuntu isn't detected
• Make driverhelper.py exit gracefully when it's not run in ubuntu (sorry, it actually does that, but it needs proper shebang)

Sscottlu 2012-12-20 github

It should be exiting gracefully. Can you run Steam from the command line ad see if there is any output from the script and paste it here? That will let us see why it isn't exiting gracefully. Thanks.

Sswiftgeek 2012-12-20 github

I should open code first -.-

If one want to use the freshest python2.x — use #!/usr/bin/python2
python3 is »4« years old… this is getting as ridiculous as transition from php4→5

Works ok after that change, but every time i restart steam, it's overwriting it :/

Sscottlu 2012-12-20 github

That's a bug, we'll fix that. Unfortunately, some distros aren't yet conforming to the /usr/bin/steam2 scheme (Debian for example), so instead we're making this script python2 and python3 compatible, for now.

Sswiftgeek 2012-12-20 github

Downloaded a package from sid
there is /usr/bin/python2.7 which is good enough — it's a last from 2.x series

?ghost 2012-12-20 github

Ubuntu 12.04 LTS is the only supported distro right now so this bug is invalid.

Sswiftgeek 2012-12-20 github

It isn't invalid since it requires one line code change to work everywhere -.-
#/usr/bin/python2.7
That's all

Sscottlu 2012-12-20 github

Swift, although Debian has 2.x, last I checked it did not (yet) install a /usr/bin/python2 symlink.

Referring to python2.7 may solve it (good point) assuming that is available on all distros (likely is).

?ghost 2012-12-20 github

@swiftgeek It does not require the change because its not intended to support other distros.

Sswiftgeek 2012-12-20 github

Same as with libappindicator and multilib, right?
https://gist.github.com/4293782

I'm waiting for real VALVe response

?ghost 2012-12-20 github

"The goal of the Steam client project is a fully-featured Steam client running on Ubuntu 12.04." <- From the Valve for Linux Blog.

Also if you now look on the site since its open to public it clearly states the only platform the support is Ubuntu 12.04 LTS. They have been pretty clear about this from the get go so filing bugs for a unsupported platform makes this a invalid bug.

Bbiltongza 2012-12-20 github
Traceback (most recent call last):
  File "/media/F/steam4linux/Steam/ubuntu12_32/driverhelper.py", line 431, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/media/F/steam4linux/Steam/ubuntu12_32/driverhelper.py", line 368, in main
    pkgInfo.init((args[1], args[2], args[3]))
  File "/media/F/steam4linux/Steam/ubuntu12_32/driverhelper.py", line 276, in init
    f = file(self.cache_file, 'w')
NameError: global name 'file' is not defined

That's what I get on Arch. Minor issue so it doesn't need high priority.

Sswiftgeek 2012-12-20 github

It doesn't matter since it has special routine in case of running it on NOT ubuntu
But since it has broken hashbang it never will work

There is also this line (doesn't rly helps)

Changing this to True disables this script, preventing video driver detection in Steam

disable_helper = False

Which also cannot be edited due to some kind of integrity checking.

But You can override content of that file during install stage of bootstrap (Ctrl-Z in terminal)
This way it wont be replaced in next runs ;)

Sscottlu 2012-12-20 github

We'll fix it, thanks for the bug report.

Sscottlu 2013-01-09 github

This is fixed in the latest release, in that it properly runs and exits without doing anything if not on an ubuntu system. In the future we'll move this script into the package so that it distros can provide this script to steam to do distro specific checks.

Sswiftgeek 2013-01-09 github

Is this soon™ kind of future or should we just start mimic current script? (writing such script may take longer time using just spare-time)

Nothing extracted yet.