install script steam{,.sh} is not POSIX compliant

steamclosed Feature Requestreviewed

ValveSoftware/steam-for-linux#623 · opened 2013-01-09 by hasufell · updated 2019-07-18 · 5 comments · github

Hhasufell 2013-01-09 github

It would be a portability improvement to make the install scripts posix compliant without forcing a particular shell (in this case bash).

proposing patch: https://gist.github.com/6d85b0c4d234641fc112

for references about bashisms, see:
http://mywiki.wooledge.org/Bashism
https://wiki.ubuntu.com/DashAsBinSh

you can check for bashisms with this popular perl script: http://sourceforge.net/projects/checkbaskisms/

Vvelociostrich 2013-01-11 github

I see you're using $() in a number of places. That is itself a bashism; you should use backticks (`) instead.

Hhasufell 2013-01-11 github

afais $() is defined in POSIX
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03

however, it would probably be fine to fix it to `` syntax although I remember there are slight differences, will test that first

Vvelociostrich 2013-01-11 github

How about that. I swear there was a version of dash (FOSS sh implementation) whose man page did not list $(). Either I'm mistaken or there was in fact a version of dash that lacked $(). (Which would not have made dash POSIX compliant, and I just incorrectly assumed that it's man page was in line with POSIX.)

Hhasufell 2013-01-12 github

It seems to be invalid syntax in "tcsh"... seems that this shell is not posix compliant after all.

Hhasufell 2016-05-24 github

No action here, no interest in redoing, bye.

Nothing extracted yet.