HL: Automatic savegames have incorrect timestamp

steamclosed reviewedMOVED: Half-Life 1

ValveSoftware/steam-for-linux#966 · opened 2013-01-27 by johndrinkwater · updated 2019-07-18 · 8 comments · github

Jjohndrinkwater 2013-01-27 github

Timestamps are being set incorrectly when hl looks at quicksave and autosave files, so they arent correctly sorted. Below is a screenshot and a paste of ls including file access time.

2013-01-27_00001

From SteamApps/common/Half-Life/SAVE

-rw-rw-r-- 1 john 564812 2013-01-26 19:31 autosave01.sav
-rw-rw-r-- 1 john 664913 2013-01-26 19:35 autosave.sav
-rw-rw-r-- 1 john 567511 2013-01-26 19:29 quick01.sav
-rw-rw-r-- 1 john 565049 2013-01-26 19:30 quick.sav

MMajlo34 2013-01-27 github

Yes i can confirm this too .Saves have incorrect timestamp in-game.

YYulike 2013-01-28 github

I can confirm this also.

Aalfred-valve maintainer 2013-01-29 github

I don't understand the bug. The time shown in the UI for the selected autosave matches the timestamp on disk... Can you be more explicit as to the time issue?

Jjohndrinkwater 2013-01-30 github

There are two autosaves listed with different elapsed times, but with the exact same timestamp listing in halflife; outside of the game, the files have the correct timestamp - same applies for the quick??.sav saves.

If the timestamps were correctly read by hl, the quick & autosave entries would be listed the other way around with the higher elapsed time ones being above.

Cchristian-esken 2013-01-30 github

I can confirm this. I also have 2 quicksaves and 2 autosaves.

Both quicksaves show the same timestamp in Half Life, and have an actually different timestamp in the filesystem
The same goes for the 2 autosaves

It should be quite well visible in the original message from johndrinkwater. In any case, there should be only one quicksave and one autosave, right? Something is definitely amiss here.

Aalfred-valve maintainer 2013-02-01 github

You will have multiple autosaves and quicksaves, 2 is the amount the engine is currently configued to save. The save date is read from the file timestamp and we move autosaves when we age them, so the current behave is a side effect of the design of the save system.

Aalfred-valve maintainer 2013-02-05 github

Okay, for quick saves and autosaves the time stamp is the same by design (due to how we age the files). I have a bug fix pending for showing the same save game multiple times which crept in after the hd models option was enabled.

Aalfred-valve maintainer 2013-02-07 github

dupe of #1337

Nothing extracted yet.