protonscr

Commit 7e071793ecedd9bb496809d947ca63c88cb23865 breaks mfplat

wineclosed
ValveSoftware/wine#291 · opened 2025-07-21 by adolfintel · updated 2025-07-21 · 4 comments · github
Aadolfintel 2025-07-21 github

Both experimental_10.0 and bleeding-edge segfault as soon as the application tries to use mfplat to play something.

I bisected the issue to commit 7e071793ecedd9bb496809d947ca63c88cb23865.

I'm not 100% sure yet but I think it's because you don't check the sgi pointer before passing it to strcmp.

Iivyl 2025-07-21 github

Hi. Experimental went through testing and we haven't seen any crashing. Are you using normal upstream Proton or some custom build? Do you have an example of a crashing game / logs from the crash? Those would help a lot with the investigation on our side. Thanks in advance!

Aadolfintel 2025-07-21 github

It's a custom build that I use for non-steam games.

Anyway, just changing this line

if (!strcmp(sgi, "1253190") && format->audio.wFormatTag == WAVE_FORMAT_EXTENSIBLE
                && IsEqualGUID(&audio->SubFormat, &MFAudioFormat_Vorbis))

to this

if (sgi && !strcmp(sgi, "1253190") && format->audio.wFormatTag == WAVE_FORMAT_EXTENSIBLE
                && IsEqualGUID(&audio->SubFormat, &MFAudioFormat_Vorbis))

fixes the issue, it's just a null pointer.

Iivyl 2025-07-21 github

Thank you. I've pushed a fixup! to the offending commit. It should show up in this repo in a moment.

Nothing extracted yet.