protonscr

Spellforce platinum edition crash on save

dxvkclosed bugd3d9
doitsujin/dxvk#2710 · opened 2022-07-10 by 234523413432634 · updated 2022-07-28 · 11 comments · github
2234523413432634 2022-07-10 github

Game crashes when autosaving(with ESC button), quicksaving(F7) and on manual save. Happens both on windows and linux.

With dxvk 1.5.4 the game doesn't crash, but savegame preview is a black square.
Also on linux framerate is very low if i don't constantly move the cursor.

Software information

Spellforce: Platinum Edition steam

System information

  • GPU: rx5700xt
  • Driver: 22.10.01.03 on windows / Mesa 22.0.1 on linux
  • Wine version: Proton GE 7-24
  • DXVK version: 1.10.1

Apitrace file(s)

Windows: https://drive.google.com/file/d/1PJis9yE40_K-85_cEfd73kr39xamYXPm/view?usp=sharing

Log files

BBlisto91 2022-07-10 github

Hi there.
Could you quickly check if anything changes with this build.
https://github.com/doitsujin/dxvk/actions/runs/2641529958

KK0bin maintainer 2022-07-10 github

That PR should fix the crash. There isn't really anything sticking out when it comes to performance, so I dont think the performance is a DXVK issue.

2234523413432634 2022-07-10 github

That fixed the crashing for me. However, this brought another problem - RDNA cards don't render some interface elements in spellforce(healtbars, manabars, circles around selected units etc.) on windows with native d3d9.
Previous versions of DXVK fixed this, but dxvk with crash fix makes parts of the interface disappear again both on windows and linux.

BBlisto91 2022-07-10 github

In which version did it used to work? 1.10.1?
Are those elements displayed in the trace and can you provide screenshots of exactly what you mean.

KK0bin maintainer 2022-07-10 github

Please add some screenshots of what it looks like with DXVK and what it should look like.

2234523413432634 2022-07-10 github

Here is how it looks in 1.10.1 - all hud elements working as they should
20220710173800_1
Here is how it looks with dxvk from spellforce branch. It also looked like that when i was making a trace on windows.
20220710173954_1

KK0bin maintainer 2022-07-10 github

Your apitrace never has those health bars. It ends pretty much immediately after the cutscene.

2234523413432634 2022-07-10 github

Should i make another one where i select a unit with a healthbar after a cutscene?

KK0bin maintainer 2022-07-10 github

I've already identified an issue. I hope that's also what causes the missing health bars.

For reference in the future:

This is a regression caused by the null descriptor changes. Before that we used the resource-bound spec constant to get the value 0, 0, 0, 1 for unbound resources. Now we sample the null descriptor and get the value 0, 0, 0, 0.

KK0bin maintainer 2022-07-10 github

I've updated the PR with a fix for the missing UI elements.

2234523413432634 2022-07-10 github

Quickly checked it on linux and windows - UI is now displayed correctly and the game doesn't crash when saving.
I didn't expect to get a complete fix in just a day. Thank you very much!)

Nothing extracted yet.