protonscr

release tarballs are missing include/spirv, include/vulkan and include/native/directx/

dxvkclosed github bug
doitsujin/dxvk#3059 · opened 2022-11-13 by stefson · updated 2022-11-14 · 9 comments · github
Sstefson 2022-11-13 github

hey there, I just wanted to build dxvk-2.0 from source and got this result:

Target machine cpu family: x86
Target machine cpu: i686
Library d3d9 found: YES
Library d3d11 found: YES
Library dxgi found: YES
Library d3dcompiler_47 found: YES
Program i686-w64-mingw32-windres found: YES

../dxvk-2.0/meson.build:124:0: ERROR: Include dir ./include/vulkan/include does not exist.

The folder is in the tarball, but its empty. Same goes for spirv and directx header folders. Do you think its possible to fix that?

here is the meson config log: meson-log.txt.gz

thanks

BBlisto91 2022-11-13 github

Hello.
The source code is fetched automatically by GitHub and doesn't seem to care about submodules even tho it has been requested for multiple years by now.
See also https://github.com/doitsujin/dxvk/issues/3048

There might be convoluted ways around it like some CI. But haven't looked into it much. (or just manual way, I've never released anything on github)

Sstefson 2022-11-13 github

It was really great to see some sort of complete tarball release. At the moment I'm not even sure how to repack this properly locally, even if I wanted to.

Mmbriar 2022-11-13 github

What's the problem with just using git clone --recursive to obtain the source and then checking-out the v2.0 tag?

Sstefson 2022-11-13 github

yeah, you can just stop to push out the broken source tarballs then.

Mmbriar 2022-11-13 github

As mentioned in the other, already linked, issue about this, the broken source tarballs are auto-generated by github.

Ppchome 2022-11-13 github

Not a bug, IMHO
Users want everything to be bundled, but distro package maintainers usually don't want/need sources for packages that already present in system, especially if an project build and statically link some outdated versions with security flaws.

Also, i think github can't just turn a switch and start packaging submodules, because this will change behaviour of some projects build systems if they find bundled sources.

As compromise developers could provide separate source archive with all submodules included.

Eeli-schwartz 2022-11-13 github

Users want everything to be bundled, but distro package maintainers usually don't want/need sources for packages that already present in system, especially if an project build and statically link some outdated versions with security flaws.

Not sure what this means since dxvk doesn't support system versions of these headers whether installed or not.

It's not a question about distros and bundling, merely a question about whether it's at all possible to successfully configure the build without git.

It's trivial to upload tarballs that can be used without git installed: meson dist --no-tests.

That's the same thing, more or less, that people did before github (though it might be called make dist / make distcheck).

Ppchome 2022-11-14 github

@eli-schwartz

Not sure what this means since dxvk doesn't support system versions of these headers whether installed or not.

It's about "github bug" tag, "broken source tarballs" and projects using submodules on github in general. Not about dxvk in particular.

Upstream links