Posting the source of the mods you listed here for myself as a note:
https://github.com/ThirteenAG/Ultimate-ASI-Loader
https://github.com/ThirteenAG/WidescreenFixesPack/blob/master/source/NFSMostWanted.WidescreenFix/dllmain.cpp
In my case using linux with wine 10-rc6 and dxvk 2.5.3 still work, also i have amd renoir igpu and game without mods
I upload the logs where it works on 2.5.1 with the Shader loader
As a first step, please upload the logs with 2.5.3, while reproducing the failure. Working logs don't help us much in narrowing down the issue.
@WinterSnowfall
Under 2.5.2 and 2.5.3 a log file is created but it is empty, i.e. 0kb
@K0bin Unfortunately, I didn't find any source code for the shader loader except from Carbon. Unfortunately, I don't know if they'll do anything
@mrdeathjr28
stock works but it just doesn't work with the shader loader
@RuesanG Can you switch to a completely unmodified game and only use the Ultimate ASI Loader and ShaderLoader (and Widescreen Fix if you want to) mods (with the mod's IDI_*_FX files copied to the game root directory)?
@TheComputerGuy96 i tested on unmodified game (Only ASI Loader and the Shader Loader with/without the IDI_*_FX files) same game dont start
I once asked the community who use this shader loader in their mods whether they can help more, but unfortunately they can't, but in the screenshots it says that the one from Carbon could also work, but the addresses for the hooks should be changed, unfortunately I have no idea.
Need for Speed Most Wanted Clean1.zip
Log
little info with this you can start the game with the shader loader
https://github.com/doitsujin/dxvk/actions/runs/12848011982
little info with this you can start the game with the shader loader https://github.com/doitsujin/dxvk/actions/runs/12848011982
While I am happy to hear that, it makes little sense. That PR is 99.9% d3d8-only and the game you are testing uses d3d9. So unless something is wrong with our release binaries, I don't see how it would help in any way.
Edit: Coincidentally you've picked up a MSVC build. Perhaps it might be a symptom of #4448.
@RuesanG Can you do a checksum on the ShaderLoader .asi file? I want to see if we both use the exact same mod
@TheComputerGuy96
Name: XNFS-ShaderLoader-MW.asi from Xbox 360 Stuff Pack v3.2 Beta
SHA1: BA7283C726A1B9D08DD50D6D8960DFD21D0B9FAD
SHA256: B0BF39AED2E99845B9C16C4BC299DD589E6B0BE63DFB06D336E6BA59D8412E35
I would suggest to run the game with some debugger like x64dbg/x32dbg.
Keep pressing F9 until the game stuck in some exception or self exits.
Since you said that logs are empty, there's a high possibility that it will fall into some exception.
You may also do a bisect between 2.5.1 and 2.5.2 to find out which commit breaks the game. Use builds from Actions to do this.
@RuesanG So I see we're running the exact same mod .asi file
For me the game does launch when using that mod with DXVK 2.5.3 (the only thing is that I'm using Wine instead of Windows)
Because the mod uses d3dx9 libraries (specifically d3dx9_43), does installing this help?: https://www.microsoft.com/en-us/download/details.aspx?id=8109
@WinterSnowfall
I'm completely open and honest, I have no idea about it, I just took an action that was current and that's how it went
@qinlili23333
do I have to spam the F9 for so long or how do I debug it right ?
can i set the actions so that you can see what has been changed between 2.5.1 and 2.5.2
@TheComputerGuy96
I am basically the person who installs all runtimes with every Windows installation so that everything is up to date
For Actions I took the master branch
https://github.com/doitsujin/dxvk/actions/runs/12071058891 starts the game (#5248)
there must be something in between if I'm not mistaken the msvc builds worked perfectly
https://github.com/doitsujin/dxvk/actions/runs/12156309952 does not start the game (#5268)
do I have to spam the F9 for so long or how do I debug it right ?
According to logs attached, it's enough.
As expected, it's STATUS_STACK_BUFFER_OVERRUN in ucrtbase, which is Universal C Runtime library in Windows.
I would suggest to see the stack in this exception to find which module is wrong. Usually ucrtbase itself is fine, the buffer overflow is happening in user space libraries.
Edit: I checked the log in detail again.
The subcode of the exception is 0x05, which means FAST_FAIL_INVALID_ARG.
The exception appeared immediately after XNFS-ShaderLoader-MW.asi loaded.
@RuesanG Could you try and see if this build works? https://github.com/doitsujin/dxvk/actions/runs/12750843593
It's just the msvc version of the 2.5.3
I've been busy lately and haven't been able to respond or I've completely forgotten about this problem. I'm constantly checking throughout the day to see what it looks like in the NFS community and there won't be a fix from their side
@qinlili23333 Since I just installed my Windows and unfortunately I didn't back up the game data, I would have to install it again and check again somehow what the problem could be, but with your tip I would have to investigate
@Blisto91
I'll try the build later
I tried the game and it worked fine.
If you can't reproduce it, can you shelve it for now? Otherwise I'll get in touch later.
I'm currently under a lot of stress at work because I haven't been able to check again yet
I would still like to thanks for your help so far
Try with the 2.6 release when you have time and it is convenient. Hopefully it'll work
I'm going crazy it doesn't work with the 2.6 either
I can start playing with msvc output.
A new custom shader mod came out today and unfortunately it uses the same ASI file.
I wrote it in his Discord hope that he can see it somehow and fix it
If he can't find a solution then I really give up
I've ordered a copy of the game. Will see if i can reproduce then
I can also make the game available with the mods as I have installed it
We do not want any piracy on this GitHub repo whatsoever.
I can also make the game available with the mods as I have installed it
To avoid piracy, you may use https://github.com/sisong/HDiffPatch to create a original copy to your installation patch file. So no one without original copy won't be available to do piracy while anyone has the same original copy can get your installtion.
Send the single patch file only, and mark which original version is based. This will also decrease the file size to upload as only modifications are saved.
Or you may create a hash list for all files in the folder and we can check whether we have setup everything as the same.
You may use these tricks to help reproducing issue, but in any condition, DO NOT upload a full game installation.
I tried it this way, and it requires the installation steps listed.
The errors should also occur this way.
So, the installation steps:
Base game -> Patch 1.3 -> NoCD 1.3 from Reloaded (otherwise, no scripts or mods will work because they're all customized on the executable) -> ASI Loader (extract in the main folder where speed.exe is) + XNFS-ShaderLoader-MW.asi in scripts folder + the end the DXVK files
Then the game should only start in the background and then immediately quit.
@qinlili23333 I noticed that I don't need it, I have added the necessary legal files as url only this one file must be searched manually
I'm fairly sure I tried your exact steps @RuesanG and it worked perfectly fine for me with DXVK.
I did it on Linux though, that's the intended platform for DXVK.
Should work now on master. A build can be downloaded here https://github.com/doitsujin/dxvk/actions/runs/14093320792
Edit: Corrected wrong link
Fixed <3
I just want to chime in (even though I'm necroposting, sorry about that).
I'm the author of that shader loader plugin (and a part-time maintainer of the widescreen fix).
I want to apologize for my crappy shader loader (and maybe some of my widescreen fix) code that may have caused this issue. It's very old and crusty. I'm glad it helped improve DXVK, though!
I promise I'm working on something better nowadays that will not require this level of jank.
Was this actually fixed? I've tried many DXVK versions on both NVIDIA and AMD (RADV) and nothing makes the shader loader work. Also seen recently that Steam Deck users still have to delete it to work around this issue.
From the perspective of the game - the only thing I can do is make an updated version of the loader that should work properly.
The way I wrote it originally is very bad. If I remember correctly, instead of passing the call to the function that is there in the game code (in its IAT), I've made it call the same D3DX function from the library directly. (It's been a while since I made it so my memory is hazy on it)
Maybe adding in the appropriate D3DX dll would fix this issue too.
EDIT: I remember now. I did that because I made the loader use another function from the D3DX lib to load the shader objects from files (as the game doesn't import that function). When I compiled it, I did it with the newest version of the library, therefore the loader itself also imports a newer D3DX. I could try to get the lib from the old SDK to match the game version, which should theoretically resolve this issue.
I threw in d3dx9_43.dll (just guessing what it's linked against) and it changes the crash/logs a bit if that means anything. Is mixing d3dx versions expected to be stable?
I'd be happy to test the correct version or a rebuild.
Looks like the recently released SunSet mod triggers the same crash. It seems to do similar shader injection. Oddly, installing DXVK is recommended for this mod, so this must be a Linux-specific bug with DXVK?
EDIT: Eh, it still crashes with the shader loader disabled in the config, so out of scope for this issue..
Please describe your issue as accurately as possible.
"I use translator because my native language is German
Video
either I have to use DXVK 2.5.1 so that it works properly with the game or disable the shader loader which brings graphics bugs
I can upload the whole game privately for you to test so that you can test it somehow or if you have the game then I can provide the important data like the
ASI loader + Widescreen Fix
XNFS-ShaderLoader-MW.zip
If you use Windows, please check the following page: https://github.com/doitsujin/dxvk/wiki/Windows
Software information
Need for Speed Most Wanted 2005 1.3
System information
Apitrace file(s)
Dont work 0xc0000005 error
For instructions on how to use apitrace, see: https://github.com/doitsujin/dxvk/wiki/Using-Apitrace
i checked
Log files
Please attach Proton or Wine logs as a text file:
PROTON_LOG=1 %command%and attach the correspondingsteam-xxxxx.logfile in your home directory.wine game.exe > game.log 2>&1and attach the resultinggame.logfile.2.5.1.zip
I upload the logs where it works on 2.5.1 with the Shader loader