protonscr

Add driver name to hud for better readability

dxvkclosed wontfix
doitsujin/dxvk#897 · opened 2019-01-30 by shmerl · updated 2019-02-28 · 20 comments · github
Sshmerl 2019-01-30 github

Vulkan allows getting driver name through VkPhysicalDeviceDriverPropertiesKHR.driverName.

For example, for radv it reports radv and for amdvlk AMD open-source driver.

Sshmerl 2019-01-30 github

Also, opened this, may be amdvlk developers can make it more distinct.

Ddoitsujin maintainer 2019-01-31 github

And why? Where would you even put this?

I'd argue that most people who have both the proprietary AMD driver and amdvlk installed know which one they are using. RADV can be recognized by its device name, and Nvidia and Intel only have one driver each.

Granted, I could potentially add some driverinfo HUD field, but I'd prefer to spend time on useful things rather than pointless feature requests that don't even work on all drivers.

Sshmerl 2019-01-31 github

Can be recognized doesn't mean it's very obvious right away. It just improves readability. I suppose like now it says:

Driver: <version>

It can say:

Driver: <name>
Driver ver: <version>
Driver info: <info>

Or something of that sort.

Ddoitsujin maintainer 2019-01-31 github

And which part of "AMD RADV POLARIS10" does not make it clear that the driver being used is RADV?

Sshmerl 2019-01-31 github

That's not a driver name though, but "GPU id". It's not really a given it should even have RADV in it, it's just coincidental. amdvlk puts more to the point string there like Radeon RX Vega.

Mmisyltoad 2019-01-31 github

lol it having radv is coincidental

ok dude
sure
mhmm
yes
uh huh

Sshmerl 2019-01-31 github

It is coincidental in the device name. Why should it be there?

Mmisyltoad 2019-01-31 github

do you know what the word coincidence means?

Sshmerl 2019-01-31 github

It means it just occurred there, not for some specific intent. The point is, it's not the field for getting the driver name from.

Mmisyltoad 2019-01-31 github

so you do not know what the word coincidence means. got it. 👍

Sshmerl 2019-01-31 github

@Joshua-Ashton Can you please drop off-topic if you have nothing to add? Seriously, better implement the change if you have free time to comment with this stuff. I can look into making it.

Ddoitsujin maintainer 2019-01-31 github

That's not a driver name though, but "GPU id". It's not really a given it should even have RADV in it, it's just coincidental. amdvlk puts more to the point string there like Radeon RX Vega.

Yes, I know that. Doesn't change the fact that it is completely redundant for vendors with more reasonable driver situations, and also doesn't change the fact that the device name on RADV happens to have RADV in it.

Sshmerl 2019-01-31 github

Well, it's just that - happens to have it. So it's kind of distinguishable now, but not really a straight way to do it. Anyway, it's not really any critical feature, just enhancement to use more proper fields for identification. I didn't test how Intel or Nvidia populate driverName, so can't say if their values make sense.

Mmisyltoad 2019-01-31 github

I implemented this for you here:
https://github.com/Joshua-Ashton/dxvk/tree/driver-hud

All the drivers have stupid names that aren't what people call them. Not only that but it takes up a fair amount of space displaying fairly redundant information.

image

Mmisyltoad 2019-01-31 github

Bigger image of it:

image

Sshmerl 2019-01-31 github

Interesting. So that's how closed AMD driver is doing it? I guess it's in line with their AMD open source driver naming for amdvlk. I opened a proposal for them to put amdvlk in the open driver name. Not sure how they call their closed one (as in codename).

To make it less bulky, it's probably better to put name, info and version into separate fields rather than one.

Something like

Driver
  version:
  name:
  info:
Mmisyltoad 2019-01-31 github

I replied to your issue on their page about that.

It would be ill-advised for them to change their name as other games/apps may be relying on that string now to make driver-specific optimizations/workarounds.

Sshmerl 2019-01-31 github

If they have such concerns, they'll keep it, or figure out a way to combine them (like add, rather than completely change the field value).

Mmisyltoad 2019-01-31 github

Any change could disrupt things. I doubt it will happen.

Sshmerl 2019-01-31 github

Let's see what they say. amdvlk is barely used yet, so not a big problem probably.

Nothing extracted yet.