protonscr

Device filter substring matching not working

dxvkclosed can't reproduce
doitsujin/dxvk#963 · opened 2019-03-12 by win8linux · updated 2019-04-01 · 8 comments · github
Wwin8linux 2019-03-12 github

Software information

Name of the game, settings used etc.

System information

  • GPU: Radeon Vega 8/Radeon RX 560X
  • Driver: Mesa AMDGPU 18.1.0
  • Wine version: 4.3
  • DXVK version: 1.0

It seems that substring matching for the device filter setting does not work. Testing with both Metal Gear Solid V: The Phantom Pain and Sleeping Dogs: Definitive Edition, using DXVK_FILTER_DEVICE_NAME="POLARIS11" causes DXVK to fail finding the dGPU:

warn:  DXVK: No adapters found. Please check your device filter settings and Vulkan setup.

Using the dGPU's full device name with DXVK_FILTER_DEVICE_NAME="AMD RADV POLARIS11 (LLVM 7.0.0)", DXVK successfully finds it and uses it.

While this is not yet working, perhaps the README should be updated to reflect this? I've already made the necessary changes here:
https://github.com/win8linux/dxvk/commit/afe9dbceade57622d27cfb00aa5991bae000a3b3

Should I make a PR request for this?

EDIT: Oops, made a mistake with one of the env variables.

Ddoitsujin maintainer 2019-03-12 github

Should I make a PR request for this?

No, because changing the README as a "solution" is exceptionally stupid. You can however submit a PR to fix the bug.

That said, I cannot reproduce this, the device filter works fine for me. Please make sure that you actually use DXVK 1.0 and not an older version.

Ddoitsujin maintainer 2019-03-12 github

Also, what is DXVK_FAMILY_NAME supposed to be? That environment variable doesn't even exist.

Wwin8linux 2019-03-12 github

Oops, I made a mistake there. Changed it to reflect the actual env variable.

Wwin8linux 2019-03-12 github

Also, I'm certain that DXVK 1.0 is used since that's the version selected in the Lutris runner options:
image

Ddoitsujin maintainer 2019-03-12 github

Anyway, can you please attach log files?

On my system this clearly works, and since this is a standard library function there's basically no way it wouldn't work for you.

Wwin8linux 2019-03-12 github

dxgi.log

The d3d11.log file was empty.

Ddoitsujin maintainer 2019-03-12 github

Can you also post the log without that env var set?

Mmisyltoad 2019-03-14 github

I too cannot replicate this.
Substring matching works fine here and I cannot see a reason in the code for the issues you are having.