[BUG] vrcompositor assumes displayName returned by vkGetPhysicalDeviceDisplayPropertiesKHR is != NULL
Since, as mentioned, I was trying to use ALVR, and since ALVR does implement the API in question, I was able to work around it by patching it like this:
From ceff061f9ea5875c3323b2fc7750cc58a781837c Mon Sep 17 00:00:00 2001
From: Davide Depau <[email protected]>
Date: Mon, 18 Apr 2022 22:06:26 +0200
Subject: [PATCH] Workaround SteamVR issue
---
alvr/vulkan_layer/build.rs | 2 ++
alvr/vulkan_layer/layer/device_api.cpp | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/alvr/vulkan_layer/build.rs b/alvr/vulkan_layer/build.rs
index 7d305395..7b1baf4f 100644
--- a/alvr/vulkan_layer/build.rs
+++ b/alvr/vulkan_layer/build.rs
@@ -26,6 +26,8 @@ fn main() {
.cpp(true)
.files(source_files_paths)
.flag("-std=c++17")
+ .flag("-g")
+ .flag("-O0")
.flag_if_supported("-Wno-unused-parameter")
.define("VK_USE_PLATFORM_XLIB_XRANDR_EXT", None)
.include(cpp_dir)
diff --git a/alvr/vulkan_layer/layer/device_api.cpp b/alvr/vulkan_layer/layer/device_api.cpp
index e3fde103..b0a61353 100644
--- a/alvr/vulkan_layer/layer/device_api.cpp
+++ b/alvr/vulkan_layer/layer/device_api.cpp
@@ -6,6 +6,7 @@
#include <vector>
static const char *alvr_display_name = "ALVR display";
+static const char *steamvr_lol = "Valve plzfix";
const struct {
} alvr_display;
@@ -38,6 +39,13 @@ VKAPI_ATTR VkResult VKAPI_CALL wsi_layer_vkGetPhysicalDeviceDisplayPropertiesKHR
properties.planeReorderPossible = VK_FALSE;
properties.persistentContent = VK_TRUE;
}
+ if (pProperties != nullptr) {
+ for (auto *prop = pProperties; prop < (pProperties + *pPropertyCount); prop++) {
+ if (prop->displayName == nullptr) {
+ prop->displayName = steamvr_lol;
+ }
+ }
+ }
return result;
}
--
2.35.3
This does stop SteamVR from showing the "Something is wrong" window.
Unfortunately after a few seconds it crashes the GPU and the system freezes completely (SSH included). This is another issue, though, I think.
Replying to https://github.com/ValveSoftware/SteamVR-for-Linux/issues/510#issuecomment-1101725890
where do i put this patch?
Replying to [#510 (comment)](https://github.com/ValveSoftware/SteamVR-for-Linux/issues/510#issuecomment-1101725890)
where do i put this patch?
The patch is for ALVR, not vrcompositor.
I'm very late, but same issue here. ALVR + Steam + error 303 + same logs
Things worked fine up until I moved my computer. Could it be a hardware failure?
Thank you, this will be fixed in an upcoming update.
Thank you, this will be fixed in an upcoming update.
Thank you for responding so quickly!
For anyone else, I did resolve my issue. I reinstalled SteamVR, and reseated my GPU. I don't exactly know which one did it, since both things happened at the same time, but it all seemed to be fixed afterwards.
Edit: It seems I have to install SteamVR very often now. Excited for this new update, which will hopefully solve the issue.
Fixed in SteamVR beta 2.5.4
Closing per the last comment.
Nothing extracted yet.
Describe the bug
vrcompositor.realcrashes withALVRsince it assumes the vkdisplay returned byvkGetPhysicalDeviceDisplayPropertiesKHRhas a name. The vulkan docs clearly say otherwise: https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VkDisplayPropertiesKHR.htmlThe stacktrace has been obtained by replacing
vrcompositor.realwith a bash script that launches gdb instead:To Reproduce
Steps to reproduce the behavior:
alvr_launcherExpected behavior
A clear and concise description of what you expected to happen.
System Information (please complete the following information):
alvr-gitr1966.bbba0430-1nvidia-settingsorvulkaninfo | grep driverInfo:Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Note: Commenters who are also experiencing this issue are encouraged to include the "System Information" section in their replies.